+1 (Binding) * Built from source * Verified Checksums * Verified Signatures * Verified no diff b/w the git tag & src tar * Verified LICENSE & NOTICE files * Compiled hadoop trunk with 1.2.0-RC1*
Thanx Shilun Fan & Xiaoqiao He for driving the release. Good Luck!!! * You need to change that protobuf artifact name to compile, that ain't fancy at all, the exclusions and all need to be updated after every release, this thing we should change maybe from next release and let the dependency stay without the version suffix. Incompatible for sure, but the current approach isn't very compatible either, If someone is having a dependency of any hadoop module, which pulls in this shaded jar transitively, that guy needs to update his exclusions post every release and that IMO isn't a very good experience, lets chase that in our next release or have some discussions around it.... -Ayush On Tue, 6 Feb 2024 at 19:14, Takanobu Asanuma <tasan...@apache.org> wrote: > +1 (binding). > > * Verified signatures and checksums > * Reviewed the documents > * Successfully built from source with `mvn clean install` > * Successfully compiled Hadoop trunk and branch-3.4 with `mvn clean install > -DskipTests` using the thirdparty 1.2.0-RC1 > * There are not any diffs between tag and src > > Regards, > - Takanobu Asanuma > > 2024年2月6日(火) 11:03 Xiaoqiao He <hexiaoq...@apache.org>: > > > cc @PJ Fanning <fannin...@apache.org> @Ayush Saxena <ayush...@gmail.com> > @Steve > > Loughran <ste...@cloudera.com> @Takanobu Asanuma <tasan...@apache.org> > @Shuyan > > Zhang <zhangshu...@apache.org> @inigo...@apache.org <inigo...@apache.org > > > > > > On Mon, Feb 5, 2024 at 11:30 AM Xiaoqiao He <hexiaoq...@apache.org> > wrote: > > > >> +1(binding). > >> > >> I checked the following items: > >> - [X] Download links are valid. > >> - [X] Checksums and PGP signatures are valid. > >> - [X] LICENSE and NOTICE files are correct for the repository. > >> - [X] Source code artifacts have correct names matching the current > >> release. > >> - [X] All files have license headers if necessary. > >> - [X] Building is OK using `mvn clean install` on JDK_1.8.0_202. > >> - [X] Built Hadoop trunk successfully with updated thirdparty (include > >> update protobuf shaded path). > >> - [X] No difference between tag and release src tar. > >> > >> Good Luck! > >> > >> Best Regards, > >> - He Xiaoqiao > >> > >> > >> On Sun, Feb 4, 2024 at 10:29 PM slfan1989 <slfan1...@apache.org> wrote: > >> > >>> Hi folks, > >>> > >>> Xiaoqiao He and I have put together a release candidate (RC1) for > Hadoop > >>> Thirdparty 1.2.0. > >>> > >>> The RC is available at: > >>> > https://dist.apache.org/repos/dist/dev/hadoop/hadoop-thirdparty-1.2.0-RC1 > >>> > >>> The RC tag is > >>> > >>> > https://github.com/apache/hadoop-thirdparty/releases/tag/release-1.2.0-RC1 > >>> > >>> The maven artifacts are staged at > >>> > https://repository.apache.org/content/repositories/orgapachehadoop-1401 > >>> > >>> Comparing to 1.1.1, there are three additional fixes: > >>> > >>> HADOOP-18197. Upgrade Protobuf-Java to 3.21.12 > >>> https://github.com/apache/hadoop-thirdparty/pull/26 > >>> > >>> HADOOP-18921. Upgrade to avro 1.11.3 > >>> https://github.com/apache/hadoop-thirdparty/pull/24 > >>> > >>> HADOOP-18843. Guava version 32.0.1 bump to fix CVE-2023-2976 (#23) > >>> https://github.com/apache/hadoop-thirdparty/pull/23 > >>> > >>> You can find my public key at : > >>> https://dist.apache.org/repos/dist/release/hadoop/common/KEYS > >>> > >>> Best Regards, > >>> Shilun Fan. > >>> > >>> >
