[
https://issues.apache.org/jira/browse/YARN-11704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17866102#comment-17866102
]
ASF GitHub Bot commented on YARN-11704:
---------------------------------------
slfan1989 commented on code in PR #6940:
URL: https://github.com/apache/hadoop/pull/6940#discussion_r1678018744
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/constraint/TestPlacementConstraintManagerService.java:
##########
@@ -194,10 +194,8 @@ public void testGetRequestConstraint() {
// AC = null
// GC = null
constraint = pcm.getMultilevelConstraint(appId1, null, c1);
- Assert.assertTrue(constraint.getConstraintExpr() instanceof And);
- mergedConstraint = (And) constraint.getConstraintExpr();
- Assert.assertEquals(1, mergedConstraint.getChildren().size());
- Assert.assertEquals(c1, mergedConstraint.getChildren().get(0).build());
+ Assert.assertTrue(constraint.getConstraintExpr().getClass() ==
c1.getConstraintExpr().getClass());
Review Comment:
checkstyle issue.
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6940/1/artifact/out/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
> Avoid nested 'AND' placement constraint for non tags in scheduling request
> --------------------------------------------------------------------------
>
> Key: YARN-11704
> URL: https://issues.apache.org/jira/browse/YARN-11704
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: capacity scheduler
> Reporter: Junfan Zhang
> Assignee: Junfan Zhang
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
