[
https://issues.apache.org/jira/browse/YARN-11786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932478#comment-17932478
]
ASF GitHub Bot commented on YARN-11786:
---------------------------------------
slfan1989 commented on code in PR #7453:
URL: https://github.com/apache/hadoop/pull/7453#discussion_r1980526233
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests/src/test/java/org/apache/hadoop/yarn/server/timelineservice/reader/AbstractTimelineReaderHBaseTestBase.java:
##########
@@ -109,19 +106,25 @@ protected void addFilters(Configuration conf) {
}
protected Client createClient() {
- ClientConfig cfg = new DefaultClientConfig();
- cfg.getClasses().add(YarnJacksonJaxbJsonProvider.class);
- return new Client(
- new URLConnectionClientHandler(new DummyURLConnectionFactory()), cfg);
+ final ClientConfig cc = new ClientConfig();
+ cc.connectorProvider(getHttpURLConnectionFactory());
+ return ClientBuilder.newClient(cc)
+ .register(TimelineEntityReader.class)
Review Comment:
@cnauroth Thank you for your message. We need to ensure the compatibility of
the interfaces. For the YARN REST API, most interfaces have no compatibility
issues. Even after upgrading to Jersey 2, the changes to the server's
WebService are minimal, usually just adding readers and writers. While there
are still a few interfaces that need re-validation, I have a general
understanding of the areas that need to be checked. We can work together to
complete this task, which must be done before the release of 3.5.0.
> Upgrade hadoop-yarn-server-timelineservice-hbase-tests to Support Trunk
> Compilation and Remove compatible hadoop version.
> -------------------------------------------------------------------------------------------------------------------------
>
> Key: YARN-11786
> URL: https://issues.apache.org/jira/browse/YARN-11786
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: timelineservice
> Affects Versions: 3.5.0
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Major
> Labels: pull-request-available
>
> The {{hadoop-yarn-server-timelineservice-hbase-tests}} module is currently
> using the compatible Hadoop version 3.3.6, which causes the following issues:
> # We are unable to upgrade the Jersey version because we made necessary
> improvements on the trunk branch, but these changes have not been
> synchronized to the Hadoop-3.3.6 branch.
> # We cannot upgrade the JUnit version because part of the module's code
> depends on the trunk branch, while another part depends on Hadoop-3.3.6.
> In this JIRA, we will attempt to make the
> {{hadoop-yarn-server-timelineservice-hbase-tests}} module successfully
> compile and run unit tests on the trunk branch, while removing support for
> the compatible Hadoop version.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
