[
https://issues.apache.org/jira/browse/YARN-11796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937356#comment-17937356
]
ASF GitHub Bot commented on YARN-11796:
---------------------------------------
stoty commented on code in PR #7512:
URL: https://github.com/apache/hadoop/pull/7512#discussion_r2007262765
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestLinuxContainerExecutorWithMocks.java:
##########
@@ -311,6 +312,12 @@ public void testStartLocalizer() throws IOException {
.build());
List<String> result=readMockParams();
+
+ if (Shell.isJavaVersionAtLeast(17)) {
+
assertTrue(result.remove("--add-exports=java.base/sun.net.dns=ALL-UNNAMED"));
+
assertTrue(result.remove("--add-exports=java.base/sun.net.util=ALL-UNNAMED"));
Review Comment:
As fot comments, most tests in TestContainerLocalizer already have similar
ifs for JDK17 (I guess these were just added later, and never tested with
JDK17).
Would you like me to add comments to those as well ?
> Accept extra JDK 17 options in tests
> ------------------------------------
>
> Key: YARN-11796
> URL: https://issues.apache.org/jira/browse/YARN-11796
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Major
> Labels: pull-request-available
>
> Yarn has some hacks that add certain JVM module options ifJDK17 or later is
> detected.
> However, not all tests have been updated to handle this, and some fail when
> encountering these when run on JDK17+.
> Fix the tests to handle these extra options.
> (There should probably be more module options added, and most of those should
> also be added for earlier JVM versions, but that's a different issue)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
