[ 
https://issues.apache.org/jira/browse/YARN-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448140#comment-13448140
 ] 

Vinod Kumar Vavilapalli commented on YARN-78:
---------------------------------------------

Makes sense.

But you still need to fix the run() method to make sure client is stopped 
correctly. I think instead of my earlier suggestion of extending 
YarnClientImpl, implementing Service is better for you since you can then shut 
down client as part of {{stop()}} and create it as part of {{start()}}.
                
> Change UnmanagedAMLauncher to use YarnClientImpl
> ------------------------------------------------
>
>                 Key: YARN-78
>                 URL: https://issues.apache.org/jira/browse/YARN-78
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.1.0-alpha, 2.2.0-alpha
>            Reporter: Bikas Saha
>            Assignee: Bikas Saha
>         Attachments: YARN-78.1.patch
>
>
> YARN-29 added a common client impl to talk to the RM. Use that in the 
> UnmanagedAMLauncher.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to