[
https://issues.apache.org/jira/browse/YARN-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459187#comment-13459187
]
Mayank Bansal commented on YARN-33:
-----------------------------------
Hi Sid,
Thanks for the review.
>> I think it's better to fail early, rather than silently running a system
>> with fewer disks than intended. In this case, we should generate errors
>> instead of ignoring the badly configured dirs, or count the bad dirs towards
>> unhealthy disks. Thoughts ?
>>>> I think we already do that right now. We have functions which removes the
>>>> unhealthy log dirs and local dirs from the list. I followed the same
>>>> model. I think its reasonable for the log/local dirs because people may
>>>> have added multiple but if one of them is good we should be able to make
>>>> cluster functioning and with the error message in the log that following
>>>> disks are in bad shape.
Thoughts?
>>The unit test doesn't really belong to TestDirectoryCollection. It can be in
>>a separate class - something like TestLocalDirsHandlerService. Also I don't
>>think the test needs to attempt deleting any files. Just verifying the number
>>of dirs / expected dirs should be sufficient.
>>>> I will create the new class however deleting was in attempt to demonstrate
>>>> that after this change there is no unwanted directories.
>>Additional unit tests, which verify alternate schems are handled as they
>>should be.
>>>> Agreed, will add the unit tests.
Thanks,
Mayank
> LocalDirsHandler should validate the configured local and log dirs
> ------------------------------------------------------------------
>
> Key: YARN-33
> URL: https://issues.apache.org/jira/browse/YARN-33
> Project: Hadoop YARN
> Issue Type: Bug
> Components: nodemanager
> Affects Versions: 2.0.2-alpha
> Reporter: Mayank Bansal
> Assignee: Mayank Bansal
> Attachments: YARN-33-trunk-v1.patch, YARN-33-trunk-v2.patch
>
>
> WHen yarn.nodemanager.log-dirs is with file:// URI then startup of node
> manager creates the directory like file:// under CWD.
> WHich should not be there.
> Thanks,
> Mayank
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
