[ 
https://issues.apache.org/jira/browse/YARN-116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Harsh J updated YARN-116:
-------------------------

    Description: 
The "yarn.resourcemanager.nodes.include-path" default value is "", if we need 
to add an include file, we must currently restart the RM. 

I suggest that for adding an include or exclude file, there should be no need 
to restart the RM. We may only execute the refresh command. The HDFS NameNode 
already has this ability.

Fix is to the modify HostsFileReader class instances:

From:
{code}
public HostsFileReader(String inFile, 
                         String exFile)
{code}
To:
{code}
 public HostsFileReader(Configuration conf, 
                         String NODES_INCLUDE_FILE_PATH,String 
DEFAULT_NODES_INCLUDE_FILE_PATH,
                        String NODES_EXCLUDE_FILE_PATH,String 
DEFAULT_NODES_EXCLUDE_FILE_PATH)
{code}

And thus, we can read the config file dynamically when a {{refreshNodes}} is 
invoked and therefore have no need to restart the ResourceManager.


  was:
"yarn.resourcemanager.nodes.include-path" default value is "", if we need add 
one include file. and we must restart the RM. 
I suggest that adding one include or exclude file, no need restart the RM. only 
execute the refresh command.
NN is the same.

Modify the HostsFileReader class:

public HostsFileReader(String inFile, 
                         String exFile)

to

 public HostsFileReader(Configuration conf, 
                         String NODES_INCLUDE_FILE_PATH,String 
DEFAULT_NODES_INCLUDE_FILE_PATH,
                        String NODES_EXCLUDE_FILE_PATH,String 
DEFAULT_NODES_EXCLUDE_FILE_PATH)


and thus, we can read the config file dynamic. and no need to restart the NM/NN.


    
> RM is missing ability to add include/exclude files without a restart
> --------------------------------------------------------------------
>
>                 Key: YARN-116
>                 URL: https://issues.apache.org/jira/browse/YARN-116
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>    Affects Versions: 2.0.0-alpha
>            Reporter: xieguiming
>         Attachments: HADOOP-835-0.patch, HADOOP-835-1.patch, HADOOP-835.patch
>
>
> The "yarn.resourcemanager.nodes.include-path" default value is "", if we need 
> to add an include file, we must currently restart the RM. 
> I suggest that for adding an include or exclude file, there should be no need 
> to restart the RM. We may only execute the refresh command. The HDFS NameNode 
> already has this ability.
> Fix is to the modify HostsFileReader class instances:
> From:
> {code}
> public HostsFileReader(String inFile, 
>                          String exFile)
> {code}
> To:
> {code}
>  public HostsFileReader(Configuration conf, 
>                          String NODES_INCLUDE_FILE_PATH,String 
> DEFAULT_NODES_INCLUDE_FILE_PATH,
>                         String NODES_EXCLUDE_FILE_PATH,String 
> DEFAULT_NODES_EXCLUDE_FILE_PATH)
> {code}
> And thus, we can read the config file dynamically when a {{refreshNodes}} is 
> invoked and therefore have no need to restart the ResourceManager.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to