[ https://issues.apache.org/jira/browse/YARN-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462756#comment-13462756 ]
Hadoop QA commented on YARN-129: -------------------------------- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12546510/YARN-129.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-unmanaged-am-launcher. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/52//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/52//console This message is automatically generated. > Simplify classpath construction for mini YARN tests > --------------------------------------------------- > > Key: YARN-129 > URL: https://issues.apache.org/jira/browse/YARN-129 > Project: Hadoop YARN > Issue Type: Improvement > Components: client > Reporter: Tom White > Assignee: Tom White > Fix For: 2.0.3-alpha > > Attachments: YARN-129.patch, YARN-129.patch > > > The test classpath includes a special file called 'mrapp-generated-classpath' > (or similar in distributed shell) that is constructed at build time, and > whose contents are a classpath with all the dependencies needed to run the > tests. When the classpath for a container (e.g. the AM) is constructed the > contents of mrapp-generated-classpath is read and added to the classpath, and > the file itself is then added to the classpath so that later when the AM > constructs a classpath for a task container it can propagate the test > classpath correctly. > This mechanism can be drastically simplified by propagating the system > classpath of the current JVM (read from the java.class.path property) to a > launched JVM, but only if running in the context of the mini YARN cluster. > Any tests that use the mini YARN cluster will automatically work with this > change. Although any that explicitly deal with mrapp-generated-classpath can > be simplified. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira