[
https://issues.apache.org/jira/browse/YARN-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466045#comment-13466045
]
Hadoop QA commented on YARN-116:
--------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12546208/YARN-116.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-YARN-Build/56//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/56//console
This message is automatically generated.
> RM is missing ability to add include/exclude files without a restart
> --------------------------------------------------------------------
>
> Key: YARN-116
> URL: https://issues.apache.org/jira/browse/YARN-116
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
> Affects Versions: 2.0.0-alpha
> Reporter: xieguiming
> Attachments: HADOOP-835-0.patch, HADOOP-835-1.patch,
> HADOOP-835.patch, YARN-116.patch
>
>
> The "yarn.resourcemanager.nodes.include-path" default value is "", if we need
> to add an include file, we must currently restart the RM.
> I suggest that for adding an include or exclude file, there should be no need
> to restart the RM. We may only execute the refresh command. The HDFS NameNode
> already has this ability.
> Fix is to the modify HostsFileReader class instances:
> From:
> {code}
> public HostsFileReader(String inFile,
> String exFile)
> {code}
> To:
> {code}
> public HostsFileReader(Configuration conf,
> String NODES_INCLUDE_FILE_PATH,String
> DEFAULT_NODES_INCLUDE_FILE_PATH,
> String NODES_EXCLUDE_FILE_PATH,String
> DEFAULT_NODES_EXCLUDE_FILE_PATH)
> {code}
> And thus, we can read the config file dynamically when a {{refreshNodes}} is
> invoked and therefore have no need to restart the ResourceManager.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
