[ 
https://issues.apache.org/jira/browse/YARN-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498726#comment-13498726
 ] 

Bikas Saha commented on YARN-128:
---------------------------------

1) Unless I am mistaken, the test condition is correct. app1 is the app 
actually submitted while appState is the state retrieved from the store. By 
checking that both are the same, we are checking that the data that was 
supposed to be passed has actually been passed to the store and there is no bug 
in the transfer of that data. The assert will be false if the transfer does not 
happen or some other value gets passed by mistake. Does that help clarify?

3) Which resource value is this? The one that is store in 
ApplicationSubmissionContext->ContainerLaunchContext? In the patch, the 
ApplicationSubmissionContext is being store at the very beginning to ensure 
that the client does not have to submit the job again. Hence, the Resource set 
by the client is saved. I am not sure what your project is saving after the 
scheduling is done. 
You are right. We dont want to store the updated value since this updated value 
is a side-effect of the policy of the scheduler.

I am not sure if this applies to your project. I will be shortly posting an 
Zookeeper and HDFS state store that you could use unless you are using your own 
storage mechanism.
                
> Resurrect RM Restart 
> ---------------------
>
>                 Key: YARN-128
>                 URL: https://issues.apache.org/jira/browse/YARN-128
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>    Affects Versions: 2.0.0-alpha
>            Reporter: Arun C Murthy
>            Assignee: Bikas Saha
>         Attachments: MR-4343.1.patch, RM-recovery-initial-thoughts.txt, 
> RMRestartPhase1.pdf, YARN-128.full-code.3.patch, YARN-128.full-code-4.patch, 
> YARN-128.new-code-added.3.patch, YARN-128.new-code-added-4.patch, 
> YARN-128.old-code-removed.3.patch, YARN-128.old-code-removed.4.patch, 
> YARN-128.patch
>
>
> We should resurrect 'RM Restart' which we disabled sometime during the RM 
> refactor.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to