[
https://issues.apache.org/jira/browse/YARN-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505398#comment-13505398
]
Tom White commented on YARN-72:
-------------------------------
I don't think it needs to be configurable, since it's a best effort cleanup
anyway. What you have seems reasonable to me, although you might want to make
the 1000 a constant so it's clear what it is for (slop value).
Does the test fail without the change?
Nit: I would change waitForContainersOnShutdownMs to
waitForContainersOnShutdownMillis.
> NM should handle cleaning up containers when it shuts down ( and kill
> containers from an earlier instance when it comes back up after an unclean
> shutdown )
> -----------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: YARN-72
> URL: https://issues.apache.org/jira/browse/YARN-72
> Project: Hadoop YARN
> Issue Type: Bug
> Components: nodemanager
> Reporter: Hitesh Shah
> Assignee: Sandy Ryza
> Attachments: YARN-72-1.patch, YARN-72.patch
>
>
> Ideally, the NM should wait for a limited amount of time when it gets a
> shutdown signal for existing containers to complete and kill the containers (
> if we pick an aggressive approach ) after this time interval.
> For NMs which come up after an unclean shutdown, the NM should look through
> its directories for existing container.pids and try and kill an existing
> containers matching the pids found.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
