[ 
https://issues.apache.org/jira/browse/YARN-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528407#comment-13528407
 ] 

Chris Nauroth commented on YARN-259:
------------------------------------

Thanks, Xuan.  I applied the new patch and ran {{TestLogAggregationService}} as 
a sample, and it passed.

I think there is one more change we need to make.  The {{Path}} constructor 
internally will translate {{URISyntaxException}} to 
{{IllegalArgumentException}}.  (See {{Path#initialize}}.)  In 
{{LocalDirsHandlerService}}, we probably want to keep the old {{catch}} block, 
but switch it to catch {{IllegalArgumentException}} instead of 
{{URISyntaxException}}.  I'm not sure if any callers of {{validatePaths}} are 
expecting {{IllegalArgumentException}}, so if we preserve the behavior of 
translating errors to {{YarnException}}, then the change will be 
backwards-compatible.

Also, if {{URISyntaxException}} is no longer referenced anywhere in this class, 
then you can remove it from the imports at the top of the file.

                
> YARN and MapReduce have multiple test failures on Windows due to rejection of 
> invalid test data path
> ----------------------------------------------------------------------------------------------------
>
>                 Key: YARN-259
>                 URL: https://issues.apache.org/jira/browse/YARN-259
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: applications
>    Affects Versions: trunk-win
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: YARN-259.branch-trunk-win.1.patch, 
> YARN-259-branch-trunk-win.2.patch
>
>
> Initialization of {{MiniMRCluster}} or {{MiniYARNCluster}} fails due to 
> presence of drive spec in testing data path.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to