[ 
https://issues.apache.org/jira/browse/YARN-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540131#comment-13540131
 ] 

Siddharth Seth commented on YARN-142:
-------------------------------------

Xuan, thanks for looking into this.

https://issues.apache.org/jira/browse/MAPREDUCE-4067?focusedCommentId=13269876&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269876
Comment on the original patch from MR-4067.

I think it'd be useful to have the APIs throw IOException and 
YarnRemoteException. The IOException indicating errors from the RPC layer, 
YarnException indicating errors from Yarn itself.
Rename YarnRemoteException to YarnException after the patch is reviewed.
Adding additional exception types - such as  UnknownAppId, UnknownContainer, 
AppAlreadyUnregistered, MisconfiguredQueueException, UnknownQueueException etc 
can be added later - if they're of any use - other than providing debug 
information, which can be inferred from reasonable error messages.

Comments on the current patch.
- It seems to have some spillover from another patch - NodeStatusUpdaterImpl 
refers to backOff and a couple other new fields.
- LocalizationProtocol..LocalResourceStatus serializes an exception from the 
Localizer. This can't be changed to IOException - needs to be a 
PBSerializedException. In the previous patch, I had moved 
YarnRemoteExceptionPBImpl over to SerializedException for this particular case.
                
> Change YARN APIs to throw IOException
> -------------------------------------
>
>                 Key: YARN-142
>                 URL: https://issues.apache.org/jira/browse/YARN-142
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 0.23.3, 2.0.0-alpha
>            Reporter: Siddharth Seth
>            Assignee: Xuan Gong
>            Priority: Critical
>         Attachments: YARN-142.1.patch
>
>
> Ref: MAPREDUCE-4067
> All YARN APIs currently throw YarnRemoteException.
> 1) This cannot be extended in it's current form.
> 2) The RPC layer can throw IOExceptions. These end up showing up as 
> UndeclaredThrowableExceptions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to