[
https://issues.apache.org/jira/browse/YARN-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13553289#comment-13553289
]
Eli Collins edited comment on YARN-340 at 1/14/13 11:55 PM:
------------------------------------------------------------
Yea, that's why I suggested SingleResourceCalculator as well, what do you think
of using it? I actually think your original name was better (and don't think
we'll end up with that many permutations in practice which is why I went with
MemoryResourceCalculator) but if people are concerned with that at least
SingleResourceCalculator means we won't proliferate as many but we'll still be
able to change the default in the future without renaming classes or having the
DefaultResourceCalculator not actually be the default.
was (Author: eli):
Yea, that's why I suggested SingleResourceCalculator as well, what do you
think of using it? I actually think you're original name was bedtter (and
don't think we'll end up with that many permutations in practice which is I
think MemoryResourceCalculator is best) but if people are concerned with that
at least SingleResourceCalculator means we won't proliferate as many but we'll
still be able to change the default in the future without renaming classes or
having the DefaultResourceCalculator not actually be the default.
> Rename DefaultResourceCalculator
> --------------------------------
>
> Key: YARN-340
> URL: https://issues.apache.org/jira/browse/YARN-340
> Project: Hadoop YARN
> Issue Type: Improvement
> Affects Versions: 2.0.0-alpha
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Attachments: yarn-340.txt, yarn-340.txt
>
>
> Let's rename DefaultResourceCalculator to something like
> MemoryResourceCalculator or SingleResourceCalculator. The default resource
> calculator is the one specified by
> yarn.scheduler.capacity.resource-calculator in yarn-default.xml (which may
> change). We can do this compatibly now since YARN-2 hasn't been released
> yet, but changing this later will be a pain if we ever make a different
> resource calculator the default (or DefaultResourceCalculator won't actually
> be the default, which is weird).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
