[
https://issues.apache.org/jira/browse/YARN-319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13558521#comment-13558521
]
Sandy Ryza commented on YARN-319:
---------------------------------
Thanks for writing the test! It looks great. A few nitpicks:
* The variable app_id should be named appId.
* System.out.println("ALLOC_FILE:"+ALLOC_FILE); should be removed.
* Is there a reason not to increment ATTEMPT_ID, as is done in
createSchedulingRequest.
* There are too many blank lines after the line with putIfAbsent.
* Is the second to last line necessary, as application is already assigned to
the correct RMApp?
* It's better not to rely on sleeps to wait for events to occur on other
threads, because it can cause running tests to take too long if they're high,
and cause tests to fail flakily if they're low. If I understand correctly, you
can remove the need for the first sleep by calling application.handle(...)
instead of rmContext.getDispatcher().getEventHandler().handle(...). When
waiting for the final application status to be failed, you can use a smaller
sleep inside a loop. TestNodeManagerShutdown has something like this on line
141.
> Submit a job to a queue that not allowed in fairScheduler, client will hold
> forever.
> ------------------------------------------------------------------------------------
>
> Key: YARN-319
> URL: https://issues.apache.org/jira/browse/YARN-319
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager, scheduler
> Affects Versions: 2.0.2-alpha
> Reporter: shenhong
> Fix For: 2.0.3-alpha
>
> Attachments: YARN-319-1.patch, YARN-319.patch
>
>
> RM use fairScheduler, when client submit a job to a queue, but the queue do
> not allow the user to submit job it, in this case, client will hold forever.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
