[
https://issues.apache.org/jira/browse/YARN-316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13562956#comment-13562956
]
Bikas Saha commented on YARN-316:
---------------------------------
We could mention the jira number here
{code}
+ // TODO: Remove Windows check and use this approach on all platforms after
+ // additional testing.
{code}
Who is taking care of cleaning up the contents actual testWorkDir to which this
symlink points to?
{code}
+ if (Shell.WINDOWS) {
+ // On Windows, clean up the short temporary symlink that was created to
+ // work around path length limitation.
+ String testWorkDirPath = testWorkDir.getAbsolutePath();
+ try {
+ FileContext.getLocalFSFileContext().delete(new Path(testWorkDirPath),
+ true);
+ } catch (IOException e) {
+ LOG.warn("could not cleanup symlink: " +
+ testWorkDir.getAbsolutePath());
+ }
+ }
{code}
Would be good to test for glob expansion code in testCreateJarWithClassPath().
> YARN container launch may exceed maximum Windows command line length due to
> long classpath
> ------------------------------------------------------------------------------------------
>
> Key: YARN-316
> URL: https://issues.apache.org/jira/browse/YARN-316
> Project: Hadoop YARN
> Issue Type: Bug
> Components: nodemanager
> Affects Versions: 3.0.0, trunk-win
> Reporter: Chris Nauroth
> Assignee: Chris Nauroth
> Attachments: YARN-316-branch-trunk-win.1.patch,
> YARN-316-branch-trunk-win.2.patch, YARN-316-branch-trunk-win.3.patch
>
>
> On Windows, a command line longer than 8192 characters will fail. This can
> cause YARN container launch to fail on Windows if the classpath argument
> exceeds this limit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
