[ 
https://issues.apache.org/jira/browse/YARN-316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Nauroth updated YARN-316:
-------------------------------

    Attachment: YARN-316-branch-trunk-win.4.patch

I'm uploading version 4 of the patch.

{quote}
We could mention the jira number here
{quote}

Done.

{quote}
Who is taking care of cleaning up the contents actual testWorkDir to which this 
symlink points to?
{quote}

The test working directory only gets deleted if the dev runs "mvn clean" or at 
the start of a new test run to clear out old state.  See the first few lines of 
the {{MiniYARNCluster}} constructor.  There is nothing currently that cleans up 
this directory at the end of a test run, aside from container cleanup 
activities like deleting the launch scripts.  This is the same behavior as 
trunk, and this patch doesn't change it.

{quote}
Would be good to test for glob expansion code in testCreateJarWithClassPath().
{quote}

Good catch.  Thank you.  I've updated the test to check that it picks up jar 
files (and leaves behind non-jar files) that match the wildcard.

                
> YARN container launch may exceed maximum Windows command line length due to 
> long classpath
> ------------------------------------------------------------------------------------------
>
>                 Key: YARN-316
>                 URL: https://issues.apache.org/jira/browse/YARN-316
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 3.0.0, trunk-win
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: YARN-316-branch-trunk-win.1.patch, 
> YARN-316-branch-trunk-win.2.patch, YARN-316-branch-trunk-win.3.patch, 
> YARN-316-branch-trunk-win.4.patch
>
>
> On Windows, a command line longer than 8192 characters will fail.  This can 
> cause YARN container launch to fail on Windows if the classpath argument 
> exceeds this limit.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to