[
https://issues.apache.org/jira/browse/YARN-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13572545#comment-13572545
]
Hadoop QA commented on YARN-357:
--------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12568245/YARN-357.branch-23.patch
against trunk revision .
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/384//console
This message is automatically generated.
> App submission should not be synchronized
> -----------------------------------------
>
> Key: YARN-357
> URL: https://issues.apache.org/jira/browse/YARN-357
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
> Affects Versions: 0.23.3, 3.0.0, 2.0.0-alpha
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: YARN-357.branch-23.patch, YARN-357.patch,
> YARN-357.patch, YARN-357.txt
>
>
> MAPREDUCE-2953 fixed a race condition with querying of app status by making
> {{RMClientService#submitApplication}} synchronously invoke
> {{RMAppManager#submitApplication}}. However, the {{synchronized}} keyword was
> also added to {{RMAppManager#submitApplication}} with the comment:
> bq. I made the submitApplication synchronized to keep it consistent with the
> other routines in RMAppManager although I do not believe it needs it since
> the rmapp datastructure is already a concurrentMap and I don't see anything
> else that would be an issue.
> It's been observed that app submission latency is being unnecessarily
> impacted.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
