[ 
https://issues.apache.org/jira/browse/YARN-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13574231#comment-13574231
 ] 

Thomas Graves commented on YARN-249:
------------------------------------

Thanks Ravi, a few comments and minor nits:

- can you rename activeApplications to numActiveApplications and 
pendingApplications to numPendingApplications so it matches the existing ones 
in the LeafQueue.
- TestRMWebServicesCapacitySched - can you add a test for the json output too
- Lets not make the LeafQueue.User class public.  Instead we are already 
copying the info so we can make a separate class.  Actually it would be nice to 
just use UserInfo.

- CapacitySchedulerPage please put {} around all the if statements and add a 
space after if and for before the first (
- ResourceManager.apt.vm since you will be in there can you capitalize "the" in 
description of username, memory, vCores

                
> Capacity Scheduler web page should show list of active users per queue like 
> it used to (in 1.x)
> -----------------------------------------------------------------------------------------------
>
>                 Key: YARN-249
>                 URL: https://issues.apache.org/jira/browse/YARN-249
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: capacityscheduler
>    Affects Versions: 2.0.2-alpha, 3.0.0, 0.23.5
>            Reporter: Ravi Prakash
>            Assignee: Ravi Prakash
>              Labels: scheduler, web-ui
>         Attachments: YARN-249.branch-0.23.patch, YARN-249.branch-0.23.patch, 
> YARN-249.branch-0.23.patch, YARN-249.branch-0.23.patch, 
> YARN-249.branch-0.23.patch, YARN-249.patch, YARN-249.patch, YARN-249.patch, 
> YARN-249.patch, YARN-249.patch, YARN-249.patch, YARN-249.patch, 
> YARN-249.patch, YARN-249.png
>
>
> On the jobtracker, the web ui showed the active users for each queue and how 
> much resources each of those users were using. That currently isn't being 
> displayed on the RM capacity scheduler web ui.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to