[
https://issues.apache.org/jira/browse/YARN-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13581553#comment-13581553
]
Zhijie Shen commented on YARN-193:
----------------------------------
Hi [~hitesh], I've one comment on the patch.
I've found that in the patch, the normalization with through exception if the
requested resource is larger than the configured max value. IMHO, it's better
to normalize the requested resource to the multiple of the min value, which is
also not larger than max value. For example min = 1024, max = 2560, resource =
2300. If only min value is considered, the resource will be normalized to 3072.
Then, if max value is considered, the resource should be reduce to the max
multiple of min value, but no larger than max value, i.e., 2048.
Otherwise, if the exception is anyway to be thrown in normalization, Client and
ApplicationMaster of distributed shell should be modified accordingly, because
the request resource are reset to the max value there if it is larger than the
max value. I'm feeling that it's better to have the consistent behavior.
> Scheduler.normalizeRequest does not account for allocation requests that
> exceed maximumAllocation limits
> ---------------------------------------------------------------------------------------------------------
>
> Key: YARN-193
> URL: https://issues.apache.org/jira/browse/YARN-193
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
> Affects Versions: 2.0.2-alpha, 3.0.0
> Reporter: Hitesh Shah
> Assignee: Hitesh Shah
> Attachments: MR-3796.1.patch, MR-3796.2.patch, MR-3796.3.patch,
> MR-3796.wip.patch, YARN-193.4.patch, YARN-193.5.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
