[
https://issues.apache.org/jira/browse/YARN-417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13586092#comment-13586092
]
Bikas Saha commented on YARN-417:
---------------------------------
My first comment would be to see if we can provide this functionality via a
single object instead of a combination of AMRMClient, Heartbeater and
AllocationListener. Every new object and its combination with others increases
mental complexity.
Also, while callbacks are a reasonable approach, it would be good to spend a
little time thinking about other notification mechanisms like events or futures.
Something else to think about. completedContainers and allocatedContainers are
essentially coming at the same time. Breaking them into 2 calls may open up
ordering issues.
What is the use of allocationResponse? If we call it on every heartbeat then we
are implicitly exposing it anyways. I can see the point about flexibility of
going one way or the other, but in this case, I think we should take a stand
about what exactly we want to expose to the user to make their life easy. Lets
figure out what the user interaction surface looks like and carefully create
new APIs.
> Add a poller that allows the AM to receive notifications when it is assigned
> containers
> ---------------------------------------------------------------------------------------
>
> Key: YARN-417
> URL: https://issues.apache.org/jira/browse/YARN-417
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: api, applications
> Affects Versions: 2.0.3-alpha
> Reporter: Sandy Ryza
> Assignee: Sandy Ryza
> Attachments: YARN-417.patch
>
>
> Writing AMs would be easier for some if they did not have to handle
> heartbeating to the RM on their own.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
