[ https://issues.apache.org/jira/browse/YARN-450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13605562#comment-13605562 ]
Bikas Saha commented on YARN-450: --------------------------------- For now, I like it outside of constants because that loses programming context. eg. ContainerExitStatus with fields is clearer than a few constants declared in yarnconstants IMO. +1 for the changes. Could you please rebase the patch to the latest changes and re-submit? Thanks! > Define value for * in the scheduling protocol > --------------------------------------------- > > Key: YARN-450 > URL: https://issues.apache.org/jira/browse/YARN-450 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Bikas Saha > Assignee: Zhijie Shen > Attachments: YARN-450_1.patch, YARN-450_2.patch > > > The ResourceRequest has a string field to specify node/rack locations. For > the cross-rack/cluster-wide location (ie when there is no locality > constraint) the "*" string is used everywhere. However, its not defined > anywhere and each piece of code either defines a local constant or uses the > string literal. Defining "*" in the protocol and removing other local > references from the code base will be good. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira