[
https://issues.apache.org/jira/browse/YARN-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13608919#comment-13608919
]
Robert Joseph Evans commented on YARN-109:
------------------------------------------
The findbugs is complaining that you are ignoring the return value of the
delete call. It should not be a problem so either use the return value to log
a warning when it fails or update the findbugs filter to filter out the error.
The -1 for the test timeouts is caused by a bug in the script used to detect
these, so you can either ignore it, or add a timeout to any @Test that appears
in the patch file, including the ones you didn't add :(.
In the test, please uncomment the lines to cleanup after the test. Are they
causing a problem for the test to pass? or was it just for debugging?
Also I personally would prefer to have a few small jar/tar/zip files checked
into the repository instead of generating them on they fly for the test. It
will speed up the test and have less dependencies on the system being set up
with the exact commands, i.e. bash for windows support. Although if you don't
feel like changing it I am fine with that too, most of those commands are used
by FSDownload already so it is not that critical.
> .tmp file is not deleted for localized archives
> -----------------------------------------------
>
> Key: YARN-109
> URL: https://issues.apache.org/jira/browse/YARN-109
> Project: Hadoop YARN
> Issue Type: Bug
> Components: nodemanager
> Affects Versions: 0.23.3, 2.0.0-alpha
> Reporter: Jason Lowe
> Assignee: Mayank Bansal
> Attachments: YARN-109-trunk-1.patch, YARN-109-trunk-2.patch,
> YARN-109-trunk-3.patch, YARN-109-trunk.patch
>
>
> When archives are localized they are initially created as a .tmp file and
> unpacked from that file. However the .tmp file is not deleted afterwards.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
