[
https://issues.apache.org/jira/browse/YARN-479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13609633#comment-13609633
]
Xuan Gong commented on YARN-479:
--------------------------------
Oh. I got it.
Do you think we still need a test case since testNMRegistration only covered
part of it? For example, Test what happen if NM will never get a response back,
etc. This behavior is almost the same as nm retry for connection to RM. And the
retry behavior for connection to RM has already been covered by other test
case. So, I am not sure whether we still need a new test case just for handling
heartbeat lost.
Other than that, I think the patch looks good.
Some minor format issue need to be fixed, such as extra spaces.
And this "//Waiting for rmStartIntervalMS, RM will be started" in
testNMRegistration() can be removed.
Re-phrase the error message and warning message, please. We are waiting for
heartbeat response back here.
> NM retry behavior for connection to RM should be similar for lost heartbeats
> ----------------------------------------------------------------------------
>
> Key: YARN-479
> URL: https://issues.apache.org/jira/browse/YARN-479
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Hitesh Shah
> Assignee: jian he
> Attachments: YARN-479.1.patch, YARN-479.2.patch
>
>
> Regardless of connection loss at the start or at an intermediate point, NM's
> retry behavior to the RM should follow the same flow.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
