[
https://issues.apache.org/jira/browse/YARN-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13618470#comment-13618470
]
Bikas Saha commented on YARN-444:
---------------------------------
Patch looks mostly good. I wonder why the plural has been used in the name of
the class when thats not the common pattern. The comments in
ContainerStatus.java mix the plural and singular.
> Move special container exit codes from YarnConfiguration to API
> ---------------------------------------------------------------
>
> Key: YARN-444
> URL: https://issues.apache.org/jira/browse/YARN-444
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: api, applications/distributed-shell
> Affects Versions: 2.0.3-alpha
> Reporter: Sandy Ryza
> Assignee: Sandy Ryza
> Attachments: YARN-444.patch
>
>
> YarnConfiguration currently contains the special container exit codes
> INVALID_CONTAINER_EXIT_STATUS = -1000, ABORTED_CONTAINER_EXIT_STATUS = -100,
> and DISKS_FAILED = -101.
> These are not really not really related to configuration, and
> YarnConfiguration should not become a place to put miscellaneous constants.
> Per discussion on YARN-417, appmaster writers need to be able to provide
> special handling for them, so it might make sense to move these to their own
> user-facing class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
