[
https://issues.apache.org/jira/browse/YARN-486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625614#comment-13625614
]
Xuan Gong commented on YARN-486:
--------------------------------
1. The idea is remove the ContainerId, Resource from CLC, and put
org.apache.yarn.api.records.Container into StartContainerRequest, and
when do the startContainer(StartContainerRequest), the ContainerId and
resource can be got from the Container
2. Change the StartContainerRequest api and proto, change the CLC api
and proto. Most of codes can be easily changed. Add one setContainer
statement when we build the StartContainerRequest object.
3.encapsulate Resource
object into
org.apache.hadoop.yarn.server.nodemanager.containermanager.container,
ApplicationSubmissionContext and ContainerRemoteLaunchEvent
4.fix all the related java codes and test codes, such as remove ContainerId,
Resource from BuilderUtils.newContainerLaunchContext, add Resource to
createApplicationSubmissionContext() function, set ContainerId into
StartContainerRequest, etc
> Change startContainer NM API to accept Container as a parameter and make
> ContainerLaunchContext user land
> ---------------------------------------------------------------------------------------------------------
>
> Key: YARN-486
> URL: https://issues.apache.org/jira/browse/YARN-486
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Bikas Saha
> Assignee: Xuan Gong
>
> Currently, id, resource request etc need to be copied over from Container to
> ContainerLaunchContext. This can be brittle. Also it leads to duplication of
> information (such as Resource from CLC and Resource from Container and
> Container.tokens). Sending Container directly to startContainer solves these
> problems. It also makes CLC clean by only having stuff in it that it set by
> the client/AM.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
