[
https://issues.apache.org/jira/browse/YARN-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13629819#comment-13629819
]
Xuan Gong commented on YARN-441:
--------------------------------
Patch3 self Review:
1. For each record API, we should only have getter and setter. We can keep
getter and setter which get or take the whole list
2. For the functions which get, set, remove one item from the whole list or
addAll, removeAll, clear the whole list, we can simply get the whole list
first, then do the following get, set, remove or clear actions. So, those
functions can be removed.
> Clean up unused collection methods in various APIs
> --------------------------------------------------
>
> Key: YARN-441
> URL: https://issues.apache.org/jira/browse/YARN-441
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Siddharth Seth
> Assignee: Xuan Gong
> Attachments: YARN-441.1.patch, YARN-441.2.patch, YARN-441.3.patch
>
>
> There's a bunch of unused methods like getAskCount() and getAsk(index) in
> AllocateRequest, and other interfaces. These should be removed.
> In YARN, found them in. MR will have it's own set.
> AllocateRequest
> StartContaienrResponse
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
