[ https://issues.apache.org/jira/browse/YARN-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13634210#comment-13634210 ]
Bikas Saha commented on YARN-514: --------------------------------- Looks great. Thanks for being patient with my comments. One minor nit before I commit this. "app.rmContext.getRMApps().get(app.applicationId) == app" right? {code} + LOG.info("Storing application with id " + app.applicationId); + app.rmContext.getStateStore().storeApplication( + app.rmContext.getRMApps().get(app.applicationId)); {code} Could you also please check that the patch on the related MR jira still applies cleanly. I will commit both these in succession. > Delayed store operations should not result in RM unavailability for app > submission > ---------------------------------------------------------------------------------- > > Key: YARN-514 > URL: https://issues.apache.org/jira/browse/YARN-514 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager > Reporter: Bikas Saha > Assignee: Zhijie Shen > Attachments: YARN-514.1.patch, YARN-514.2.patch, YARN-514.3.patch, > YARN-514.4.patch, YARN-514.5.patch, YARN-514.6.patch, YARN-514.7.patch > > > Currently, app submission is the only store operation performed synchronously > because the app must be stored before the request returns with success. This > makes the RM susceptible to blocking all client threads on slow store > operations, resulting in RM being perceived as unavailable by clients. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira