[ https://issues.apache.org/jira/browse/YARN-561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13634660#comment-13634660 ]
Xuan Gong commented on YARN-561: -------------------------------- bq:Any reason why NM_PORT is set by NM but not NM_HTTP_PORT? Looks like we can remove NM_PORT and use NM_HTTP_PORT instead. bq:Why does AMLauncher need to set NM* related env vars? Originally, AMLauncher set those variable for the AM Container. Now we move all the variables to Environment for all the containers. So we do not need to set those variables anymore. At ContainerLaunch, these variables will be set by NM anyway. bq:Should MapReduceChildJVM need to continue to set APPLICATION_ATTEMPT_ID_ENV? I think we do not need to. The variable APPLICATION_ATTEMPT_ID_ENV is used in two places: a. At MapReduceChildJVM, it set APPLICATION_ATTEMPT_ID_ENV with value from APPLICATION_ATTEMPT_ID b. At YarnChild, it used APPLICATION_ATTEMPT_ID_ENV to set APPLICATION_ATTEMPT_ID Originally, we set APPLICATION_ATTEMPT_ID_ENV with APPLICATION_ATTEMPT_ID, and if we try to APPLICATION_ATTEMPT_ID in future, we just read the value from APPLICATION_ATTEMPT_ID_ENV. Now, we can get APPLICATION_ATTEMPT_ID directly from ContainerId, since we export those info. > Nodemanager should set some key information into the environment of every > container that it launches. > ----------------------------------------------------------------------------------------------------- > > Key: YARN-561 > URL: https://issues.apache.org/jira/browse/YARN-561 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Hitesh Shah > Assignee: Xuan Gong > Labels: usability > Attachments: YARN-561.1.patch, YARN-561.2.patch, YARN-561.3.patch, > YARN-561.4.patch > > > Information such as containerId, nodemanager hostname, nodemanager port is > not set in the environment when any container is launched. > For an AM, the RM does all of this for it but for a container launched by an > application, all of the above need to be set by the ApplicationMaster. > At the minimum, container id would be a useful piece of information. If the > container wishes to talk to its local NM, the nodemanager related information > would also come in handy. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira