[
https://issues.apache.org/jira/browse/YARN-583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13637110#comment-13637110
]
Vinod Kumar Vavilapalli commented on YARN-583:
----------------------------------------------
The test looks good.
bq. Should getUserAppCachePath() become getAppFileCachePath() ?
Missed this?
Apologies for not covering this earlier, but may I suggest one more
improvement, not entirely related to the patch?
- We should look to make these two methods static, add in more such static
methods to get local-dir, user-dir, app-dir etc, possible relocate them to some
utils class and use them everywhere. Some places I see which manually construct
these paths:
-- ContainerLaunch
-- DefaultContainerExecutor: this already has some methods like this
-- ResourceLocalizationService: The current methods in question
-- ContainerLocalizer
-- ShuffleHandler.Shuffle
-- TestContainerLocalizer, TestContainerManager,
TestDefaultContainerExecutor and your new test in
TestResourceLocalizationService.
> Application cache files should be localized under
> local-dir/usercache/userid/appcache/appid/filecache
> -----------------------------------------------------------------------------------------------------
>
> Key: YARN-583
> URL: https://issues.apache.org/jira/browse/YARN-583
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Omkar Vinit Joshi
> Assignee: Omkar Vinit Joshi
> Attachments: yarn-583-20130416.1.patch, yarn-583-20130416.patch,
> yarn-583-20130417.patch, yarn-583-20130419.patch
>
>
> Currently application cache files are getting localized under
> local-dir/usercache/userid/appcache/appid/. however they should be localized
> under filecache sub directory.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
