[ 
https://issues.apache.org/jira/browse/YARN-595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13639587#comment-13639587
 ] 

Alejandro Abdelnur commented on YARN-595:
-----------------------------------------

patch looks good, couple of NITs:

* FairScheduler: patch is adding a bunch of System.out.println(), I guess this 
is debris from your testing, if we need to output any of this, please use the 
log.
* FSSchedulerNode: no need to initialize availableResource var on definition, 
it is always assigned in the constructor.
                
> Refactor fair scheduler to use common Resources
> -----------------------------------------------
>
>                 Key: YARN-595
>                 URL: https://issues.apache.org/jira/browse/YARN-595
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: scheduler
>    Affects Versions: 2.0.3-alpha
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>         Attachments: YARN-595.patch, YARN-595.patch
>
>
> resourcemanager.fair and resourcemanager.resources have two copies of 
> basically the same code for operations on Resource objects

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to