[
https://issues.apache.org/jira/browse/YARN-605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13640048#comment-13640048
]
Hitesh Shah commented on YARN-605:
----------------------------------
This seems to fix it:
{code}
diff --git
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/webapp/WebServicesTestUtils.java
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-
index d82771b..b1cff2c 100644
---
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/webapp/WebServicesTestUtils.java
+++
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/webapp/WebServicesTestUtils.java
@@ -76,7 +76,7 @@ public static String getXmlAttrString(Element element, String
name) {
public static void checkStringMatch(String print, String expected, String
got) {
assertTrue(
print + " doesn't match, got: " + got + " expected: " + expected,
- got.matches(expected));
+ got.equals(expected));
}
public static void checkStringContains(String print, String expected, String
got) {
{code}
[~tgraves] Any comments on whether matches() is needed? I am guessing something
in the strings ( maybe a '-' ) is causing problems when using a regex match.
> Failing unit test in TestNMWebServices when using git for source control
> -------------------------------------------------------------------------
>
> Key: YARN-605
> URL: https://issues.apache.org/jira/browse/YARN-605
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Hitesh Shah
>
> Failed tests:
> testNode(org.apache.hadoop.yarn.server.nodemanager.webapp.TestNMWebServices):
> hadoopBuildVersion doesn't match, got: 3.0.0-SNAPSHOT from
> fddcdcfb3cfe7dcc4f77c1ac953dd2cc0a890c62 (HEAD, origin/trunk, origin/HEAD,
> mrx-track) by Hitesh source checksum f89f5c9b9c9d44cf3be5c2686f2d789
> expected: 3.0.0-SNAPSHOT from fddcdcfb3cfe7dcc4f77c1ac953dd2cc0a890c62 (HEAD,
> origin/trunk, origin/HEAD, mrx-track) by Hitesh source checksum
> f89f5c9b9c9d44cf3be5c2686f2d789
>
> testNodeSlash(org.apache.hadoop.yarn.server.nodemanager.webapp.TestNMWebServices):
> hadoopBuildVersion doesn't match, got: 3.0.0-SNAPSHOT from
> fddcdcfb3cfe7dcc4f77c1ac953dd2cc0a890c62 (HEAD, origin/trunk, origin/HEAD,
> mrx-track) by Hitesh source checksum f89f5c9b9c9d44cf3be5c2686f2d789
> expected: 3.0.0-SNAPSHOT from fddcdcfb3cfe7dcc4f77c1ac953dd2cc0a890c62 (HEAD,
> origin/trunk, origin/HEAD, mrx-track) by Hitesh source checksum
> f89f5c9b9c9d44cf3be5c2686f2d789
>
> testNodeDefault(org.apache.hadoop.yarn.server.nodemanager.webapp.TestNMWebServices):
> hadoopBuildVersion doesn't match, got: 3.0.0-SNAPSHOT from
> fddcdcfb3cfe7dcc4f77c1ac953dd2cc0a890c62 (HEAD, origin/trunk, origin/HEAD,
> mrx-track) by Hitesh source checksum f89f5c9b9c9d44cf3be5c2686f2d789
> expected: 3.0.0-SNAPSHOT from fddcdcfb3cfe7dcc4f77c1ac953dd2cc0a890c62 (HEAD,
> origin/trunk, origin/HEAD, mrx-track) by Hitesh source checksum
> f89f5c9b9c9d44cf3be5c2686f2d789
>
> testNodeInfo(org.apache.hadoop.yarn.server.nodemanager.webapp.TestNMWebServices):
> hadoopBuildVersion doesn't match, got: 3.0.0-SNAPSHOT from
> fddcdcfb3cfe7dcc4f77c1ac953dd2cc0a890c62 (HEAD, origin/trunk, origin/HEAD,
> mrx-track) by Hitesh source checksum f89f5c9b9c9d44cf3be5c2686f2d789
> expected: 3.0.0-SNAPSHOT from fddcdcfb3cfe7dcc4f77c1ac953dd2cc0a890c62 (HEAD,
> origin/trunk, origin/HEAD, mrx-track) by Hitesh source checksum
> f89f5c9b9c9d44cf3be5c2686f2d789
>
> testNodeInfoSlash(org.apache.hadoop.yarn.server.nodemanager.webapp.TestNMWebServices):
> hadoopBuildVersion doesn't match, got: 3.0.0-SNAPSHOT from
> fddcdcfb3cfe7dcc4f77c1ac953dd2cc0a890c62 (HEAD, origin/trunk, origin/HEAD,
> mrx-track) by Hitesh source checksum f89f5c9b9c9d44cf3be5c2686f2d789
> expected: 3.0.0-SNAPSHOT from fddcdcfb3cfe7dcc4f77c1ac953dd2cc0a890c62 (HEAD,
> origin/trunk, origin/HEAD, mrx-track) by Hitesh source checksum
> f89f5c9b9c9d44cf3be5c2686f2d789
>
> testNodeInfoDefault(org.apache.hadoop.yarn.server.nodemanager.webapp.TestNMWebServices):
> hadoopBuildVersion doesn't match, got: 3.0.0-SNAPSHOT from
> fddcdcfb3cfe7dcc4f77c1ac953dd2cc0a890c62 (HEAD, origin/trunk, origin/HEAD,
> mrx-track) by Hitesh source checksum f89f5c9b9c9d44cf3be5c2686f2d789
> expected: 3.0.0-SNAPSHOT from fddcdcfb3cfe7dcc4f77c1ac953dd2cc0a890c62 (HEAD,
> origin/trunk, origin/HEAD, mrx-track) by Hitesh source checksum
> f89f5c9b9c9d44cf3be5c2686f2d789
>
> testSingleNodesXML(org.apache.hadoop.yarn.server.nodemanager.webapp.TestNMWebServices):
> hadoopBuildVersion doesn't match, got: 3.0.0-SNAPSHOT from
> fddcdcfb3cfe7dcc4f77c1ac953dd2cc0a890c62 (HEAD, origin/trunk, origin/HEAD,
> mrx-track) by Hitesh source checksum f89f5c9b9c9d44cf3be5c2686f2d789
> expected: 3.0.0-SNAPSHOT from fddcdcfb3cfe7dcc4f77c1ac953dd2cc0a890c62 (HEAD,
> origin/trunk, origin/HEAD, mrx-track) by Hitesh source checksum
> f89f5c9b9c9d44cf3be5c2686f2d789
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
