[ 
https://issues.apache.org/jira/browse/YARN-629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13647228#comment-13647228
 ] 

Xuan Gong commented on YARN-629:
--------------------------------

bq:Need a specific test which validates that the final exception is same as the 
one thrown on the remote side. Can you check if TestNodeManagerResync and 
TestContainerManager can be changed to validate this? Look for refs to YARN-142 
in those tests.
bq:Please create a sister JIRA in MapReduce, I'll review MR changes there but 
commit that together with this patch.
Create MR ticket. MAPREDUCE-5204
bq:Investigated the test-failures?
they are all passing now.
bq:TestClientTokens: Explicitly catch YarnRemoteException and fail instead of 
instance checks?
Can't understand the changes in TestClientRMService, explain please why we need 
to only now do e.getCause().getMessage() to capture the remote exception 
message.
YarnRemoteException is not rooted as IOException now. For ugi.doAs(), it throws 
IOException, InterruptedException, UndeclaredThrowableException,etc, but does 
not throw YarnRemoteException. So, we can not Explicitly catch 
YarnRemoteException. I think if YarnRemoteException is throw inside the doAs(), 
it will be wrapped. So by calling getCause() will get it back. 
                
> Make YarnRemoteException not be rooted at IOException
> -----------------------------------------------------
>
>                 Key: YARN-629
>                 URL: https://issues.apache.org/jira/browse/YARN-629
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Xuan Gong
>            Assignee: Xuan Gong
>         Attachments: YARN-629.1.patch, YARN-629.2.patch
>
>
> After HADOOP-9343, it should be possible for YarnException to not be rooted 
> at IOException

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to