[
https://issues.apache.org/jira/browse/YARN-422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zhijie Shen updated YARN-422:
-----------------------------
Attachment: YARN-422.3.patch
In the newest patch, there're the following significant changes:
1. NMCommunicator closes the PRC proxy every time a interaction with
NodeManager is finished.
2. No restrict order of stopping/querying/stopping container is enforced.
Because of this, NMClient#getContainerStatus and NMClient#stopContainerStatus
needs to be changed, adding two more params, i.e., NodeId and ContainerToken.
This will be used to start the PRC proxy (previously startContainer must be
called first, such that this information is already stored when the following
interactions are invoked).
3. Due to the stateless session, NMClientImpl no longer needs to keep the
NMCommunicator instances for each started container. However, NMClientImpl
still needs to remember which container is not stopped. The alive containers
need to be stopped when NMClientImpl stops. Otherwise, they may be not
stoppable.
4. CallbackHandler distinguishes the hanlders for exception happening under
each type of interaction with container. Therefore, the event type is no longer
necessary to be exposed to the public.
In addition, I've addressed the code refactoring issues mentioned in Vinod's
comments, and modified the test cases.
> Add NM client library
> ---------------------
>
> Key: YARN-422
> URL: https://issues.apache.org/jira/browse/YARN-422
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Bikas Saha
> Assignee: Zhijie Shen
> Attachments: AMNMClient_Defination.txt,
> AMNMClient_Definition_Updated_With_Tests.txt, proposal_v1.pdf,
> YARN-422.1.patch, YARN-422.2.patch, YARN-422.3.patch
>
>
> Create a simple wrapper over the ContainerManager protocol to provide hide
> the details of the protocol implementation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
