[
https://issues.apache.org/jira/browse/YARN-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13652617#comment-13652617
]
Siddharth Seth commented on YARN-634:
-------------------------------------
bq. Move SerializedException to be in server-api for now? We can move it to
public api when needed.
Sure. Will move this over.
bq. We don't need YarnRemoteException.getRemoteException* methods at all now?
Agree it is a massive change - I can file a follow up ticket.
On SerializedException, or on YarnRemoteException ? YarnRemoteException should
not require these methods - since the client will see the exception thrown by
the server. SerializedException requires an unwind method - which needs to be
added. Prefer doing this in a separate jira though; this one is more of a
refactor.
bq. Can you expose SerializedExceptionProto.class_name also in
SerializedException? We found it wanting in few JIRAs.
Sure. An unwind method would've been ideal. I'll add this for now, and we can
think of removing it if no longer required when unwind is implemented.
bq. Seems like if just have an unwind method on SerializedException, most of NM
changes are unnecessary : ContainerResourceFailedEvent, LocalizedResource,
ResourceFailedLocalizationEvent. Basically we can simply use
SerializedException at the edge and wind/unwind before and after sending across
the wire.
SerializedException is really just a yarn record to captures an error, which is
the payload on most of these FailureEvents. It's part of a method response
payload as against being thrown by the method call itself. So I don't really
see a reason to wind/unwind this at the edge. I'd prefer leaving this as is,
unless you feel strongly about it.
> Introduce a SerializedException
> -------------------------------
>
> Key: YARN-634
> URL: https://issues.apache.org/jira/browse/YARN-634
> Project: Hadoop YARN
> Issue Type: Sub-task
> Affects Versions: 2.0.4-alpha
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Attachments: YARN-634.txt
>
>
> LocalizationProtocol sends an exception over the wire. This currently uses
> YarnRemoteException. Post YARN-627, this needs to be changed and a new
> serialized exception is required.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
