[ 
https://issues.apache.org/jira/browse/YARN-634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Siddharth Seth updated YARN-634:
--------------------------------

    Attachment: YARN-634.patch.2

bq. I meant RPCUtil.getRemoteException* methods
Those aren't really needed. Simple changes, but I didn't want to remove them in 
this patch since this is already pretty big.

bq. We'll definitely need and unwrap API. Going by the class_name logic, we 
also don't need getMessage() and getRemoteTrace() in SerializedException once 
we have unwind? I'd rather implement unwrap instead of adding all this 
unnecessary functionality.
This patch is really juts moving YarnRemoteExceptionPBImpl over to 
SerializedException. After an offline conversation with Vinod, have changed the 
NM events to take an error string as a payload, since that's really what they 
care about at the moment. Unwind and SerializedException cleanup will be done 
in a separate jira. FWIW, the patch marks SerializedException as private, 
unstable.

The findbugs warning should be fixed - via an exclusion.
                
> Introduce a SerializedException
> -------------------------------
>
>                 Key: YARN-634
>                 URL: https://issues.apache.org/jira/browse/YARN-634
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>    Affects Versions: 2.0.4-alpha
>            Reporter: Siddharth Seth
>            Assignee: Siddharth Seth
>         Attachments: YARN-634.patch.2, YARN-634.txt
>
>
> LocalizationProtocol sends an exception over the wire. This currently uses 
> YarnRemoteException. Post YARN-627, this needs to be changed and a new 
> serialized exception is required.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to