[
https://issues.apache.org/jira/browse/YARN-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13655689#comment-13655689
]
Bikas Saha commented on YARN-422:
---------------------------------
Rename onExceptionRaisedWhenStartingContainer() to onStartContainerError()?
What do you say?
The comment should not say 10 since the value can change with time. Is the
initial value checked to be less than the MAX specified?
{code}
+ // Start with a default core-pool size of 10 and change it dynamically.
+ threadPool = new ThreadPoolExecutor(INITIAL_THREAD_POOL_SIZE,
+ Integer.MAX_VALUE, 1, TimeUnit.HOURS,
{code}
Improve grammar?
{code}
+ // See if we need up the pool size only if haven't reached the
+ // maximum limit yet.
{code}
Should the boolean flag set/get be part of NMClient interface itself?
{code}
+ if (!(client instanceof NMClientImpl) ||
+ ((NMClientImpl) client).stopAllRunningContainersOnStoppingEnabled())
{code}
Why is TestAMRMClient being removed?
We need to double check the synchronization/thread safety of this class. Lots
of objects and threads. Can you please document the expected locking order?
> Add NM client library
> ---------------------
>
> Key: YARN-422
> URL: https://issues.apache.org/jira/browse/YARN-422
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Bikas Saha
> Assignee: Zhijie Shen
> Attachments: AMNMClient_Defination.txt,
> AMNMClient_Definition_Updated_With_Tests.txt, proposal_v1.pdf,
> YARN-422.1.patch, YARN-422.2.patch, YARN-422.3.patch, YARN-422.4.patch,
> YARN-422.5.patch
>
>
> Create a simple wrapper over the ContainerManager protocol to provide hide
> the details of the protocol implementation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
