[
https://issues.apache.org/jira/browse/YARN-628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Siddharth Seth updated YARN-628:
--------------------------------
Attachment: YARN-628.txt
Thanks! This patch did need an exhaustive review.
bq. TestClientRMTokens: Can we explicitly test for InvalidToken? That'll be
great if possible.
Sure. Wasn't really trying to get all the exception verification in tests
cleaned up in this patch. There's more in MR tests; I'll open a separate jira
for this.
bq. TestClientTokens: The exception thrown should always be RemoteException, so
no need for the if condition, we should simply assert so.
Done.
bq. RPCUtil.instantiateException -> instantiateRemoteException?
I've left this as is. It's not instantiating a remote exception. Maybe
instantiateFromRemoteException, but I prefer the current name.
Have renamed some of the other methods, some as suggested, others with slightly
clearer names, and have added some comments to make the tests easier to
understand.
Also, added documentation to YarnRemoteException stating that derived classes
must include a String only constructor.
> Fix YarnException unwrapping
> ----------------------------
>
> Key: YARN-628
> URL: https://issues.apache.org/jira/browse/YARN-628
> Project: Hadoop YARN
> Issue Type: Sub-task
> Affects Versions: 2.0.4-alpha
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Attachments: YARN-628.txt, YARN-628.txt, YARN-628.txt, YARN-628.txt.2
>
>
> Unwrapping of YarnRemoteExceptions (currently in YarnRemoteExceptionPBImpl,
> RPCUtil post YARN-625) is broken, and often ends up throwin
> UndeclaredThrowableException. This needs to be fixed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
