[ 
https://issues.apache.org/jira/browse/YARN-568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13661691#comment-13661691
 ] 

Bikas Saha commented on YARN-568:
---------------------------------

>From the code in generatePreemptionMessage() the overlap between strict and 
>fungible is not obvious. Can both be sent?
{code}
+  private PreemptionMessage generatePreemptionMessage(Allocation allocation){
{code}

Unused new member seems to have been added: recordFactory?
{code}
 public class Allocation {
+  
+  private final RecordFactory recordFactory =
+      RecordFactoryProvider.getRecordFactory(null);
+
{code}
                
> FairScheduler: support for work-preserving preemption 
> ------------------------------------------------------
>
>                 Key: YARN-568
>                 URL: https://issues.apache.org/jira/browse/YARN-568
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: scheduler
>            Reporter: Carlo Curino
>            Assignee: Carlo Curino
>             Fix For: 2.0.5-beta
>
>         Attachments: YARN-568-1.patch, YARN-568-2.patch, YARN-568-2.patch, 
> YARN-568.patch, YARN-568.patch
>
>
> In the attached patch, we modified  the FairScheduler to substitute its 
> preemption-by-killling with a work-preserving version of preemption (followed 
> by killing if the AMs do not respond quickly enough). This should allows to 
> run preemption checking more often, but kill less often (proper tuning to be 
> investigated).  Depends on YARN-567 and YARN-45, is related to YARN-569.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to