[ 
https://issues.apache.org/jira/browse/YARN-711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jian He updated YARN-711:
-------------------------

    Attachment: YARN-711.1.patch

This patch does:
1. change record class type from interface to abstract class.
2. modify *PBImpl to extend only this abstract class and copy over the 
hashCode, equals, toString methods from ProtoBase
3. copy the factory method into the record self.

4. Do this for all yarn.api.records, except ApplicationId, ApplicationAttemptId 
and token-related records
                
> Copy BuilderUtil methods into individual records
> ------------------------------------------------
>
>                 Key: YARN-711
>                 URL: https://issues.apache.org/jira/browse/YARN-711
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Vinod Kumar Vavilapalli
>            Assignee: Vinod Kumar Vavilapalli
>         Attachments: YARN-711.1.patch
>
>
> BuilderUtils is one giant utils class which has all the factory methods 
> needed for creating records. It is painful for users to figure out how to 
> create records. We are better off having the factories in each record, that 
> way users can easily create records.
> As a first step, we should just copy all the factory methods into individual 
> classes, deprecate BuilderUtils and then slowly move all code off 
> BuilderUtils.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to