[ https://issues.apache.org/jira/browse/YARN-530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Loughran updated YARN-530: -------------------------------- Attachment: YARN-530-008.patch resubmit, main change is to downgrade the log message on service start to debug, as it appears on things like yarn client applications, where it gets in the way. # I'd like to come up with a way of postponing all service state change notifications until a service has exited the synchronized phase of the state change -to avoid all risk of deadlocks. But I can't see an easy way to do this while also guaranteeing the {{stop()}} operation will be called if a service fails to init or start -that call, with its notifications, will be called in the synchronized block. The only workable solution that is immediately obvious is have a special private {{stopNoNotifications}} call, then leave it up to the outer notifier operation in the start/stop methods to tell the listeners the state has changed. # this patch includes the {{ServiceLauncher}} and {{IrqHandler}} I mention in YARN-679. They are for completeness -not for committing. They are evolving and need more use before even ready for review. For the curious only: they show how we don't need separate entry points for every YARN service. > Define Service model strictly, implement AbstractService for robust > subclassing, migrate yarn-common services > ------------------------------------------------------------------------------------------------------------- > > Key: YARN-530 > URL: https://issues.apache.org/jira/browse/YARN-530 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Steve Loughran > Assignee: Steve Loughran > Attachments: YARN-117changes.pdf, YARN-530-005.patch, > YARN-530-008.patch, YARN-530-2.patch, YARN-530-3.patch, YARN-530.4.patch, > YARN-530.patch > > > # Extend the YARN {{Service}} interface as discussed in YARN-117 > # Implement the changes in {{AbstractService}} and {{FilterService}}. > # Migrate all services in yarn-common to the more robust service model, test. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira