[
https://issues.apache.org/jira/browse/YARN-578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13666440#comment-13666440
]
Sandy Ryza commented on YARN-578:
---------------------------------
Hi Omkar. The patch is looking good. A couple nits:
* You should use a LOG message instead of System.out.println in
ContainerLogsPage, and the "Opeing" in it is a typo.
* "Exception Reading log file." Reading should not be capitalized.
* Unnecessary whitespace change on this line:
logAggregationService.getRemoteNodeLogFileForApp(appId, this.user));
* "' doesn't own requested log file :syslog". There should be a space between
the colon and syslog.
> NodeManager should use SecureIOUtils for serving and aggregating logs
> ---------------------------------------------------------------------
>
> Key: YARN-578
> URL: https://issues.apache.org/jira/browse/YARN-578
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager
> Reporter: Vinod Kumar Vavilapalli
> Assignee: Omkar Vinit Joshi
> Attachments: yarn-578-20130426.patch, YARN-578-20130506.patch,
> YARN-578-20130520.1.patch, YARN-578-20130520.branch-2.patch,
> YARN-578-20130520.patch
>
>
> Log servlets for serving logs and the ShuffleService for serving intermediate
> outputs both should use SecureIOUtils for avoiding symlink attacks.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
