[
https://issues.apache.org/jira/browse/YARN-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13668515#comment-13668515
]
Vinod Kumar Vavilapalli commented on YARN-422:
----------------------------------------------
Few more:
TestNMClient
- setup() can wait for-ever in the application-status check.
- testContainerManagement: Validate specific exception messages.
- iterationsLeft should be 3 as you decrement and then compare?
- Why these checks? nmClient.getServiceState() == STATE.STARTED). Shouldn't be
there AFAIU.
- Also check for exact number of startedContainers instead of > 0
TestNMClientAsync:
- How are you validating that that threads aren't crashing on
RuntimeExceptions?
> Add NM client library
> ---------------------
>
> Key: YARN-422
> URL: https://issues.apache.org/jira/browse/YARN-422
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Bikas Saha
> Assignee: Zhijie Shen
> Attachments: AMNMClient_Defination.txt,
> AMNMClient_Definition_Updated_With_Tests.txt, proposal_v1.pdf,
> YARN-422.10.patch, YARN-422.11.patch, YARN-422.12.patch, YARN-422.13.patch,
> YARN-422.1.patch, YARN-422.2.patch, YARN-422.3.patch, YARN-422.4.patch,
> YARN-422.5.patch, YARN-422.6.patch, YARN-422.8.patch, YARN-422.9.patch,
> YARN-422-javadoc-fixes.txt
>
>
> Create a simple wrapper over the ContainerManager protocol to provide hide
> the details of the protocol implementation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
