[
https://issues.apache.org/jira/browse/YARN-512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13668769#comment-13668769
]
Hadoop QA commented on YARN-512:
--------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12584837/YARN-512.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/1015//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1015//console
This message is automatically generated.
> Log aggregation root directory check is more expensive than it needs to be
> --------------------------------------------------------------------------
>
> Key: YARN-512
> URL: https://issues.apache.org/jira/browse/YARN-512
> Project: Hadoop YARN
> Issue Type: Bug
> Components: nodemanager
> Affects Versions: 2.0.5-beta
> Reporter: Jason Lowe
> Assignee: Maysam Yabandeh
> Priority: Minor
> Attachments: YARN-512.patch
>
>
> The log aggregation root directory check first does an {{exists}} call
> followed by a {{getFileStatus}} call. That effectively stats the file twice.
> It should just use {{getFileStatus}} and catch {{FileNotFoundException}} to
> handle the non-existent case.
> In addition we may consider caching the presence of the directory rather than
> checking it each time a node aggregates logs for an application.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
