[
https://issues.apache.org/jira/browse/YARN-684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vinod Kumar Vavilapalli updated YARN-684:
-----------------------------------------
Attachment: YARN-684.20130530.4.txt
Tx for the review Sid. Updating the patch.
bq. TestContainerLauncherRPC sets the token to null, but tries accessing it
later. The same for a couple of other tests. Not related to this patch, but
TestContainerLauncherRPC seems to be doing more than it needs to after the
timeout - throwing an exception other than the one being verified in the test
would be simpler.
Fixed MRApp related issues. Fixed TestContainerLauncherRPC too.
bq. Since the NM webserver now exposes the http port directly, setting it in
the conf should not be necessary (Webserver.start())
Done
bq. ContainerManagerImpl getRemoteUgi - the string parameter is useful
debug information if this call fails. I don't think it needs to be removed.
We derive the ContainerID also from ContainerToken now which is after UGI
resolution, so this can't be done.
bq. selectCOntainerTokenIdentifier - assuming this will be removed as part
of one of the YARN-613 subtasks.
Yes
bq. Is the readLock required for ContainerImpl.getContainerId etc. All the
new parameters are final.
Removed the locking
bq. getContainerTokenIdentifier not required in the *nm.Container inteface ?
This is used in stopContainer and getContainerStatus today. Will be fixed after
YARN-613.
Finally, cleaned up TestContainerManagerSecurity. Most of testUnauthorized user
won't happen anymore, so removed that code. Added some valid test for
testMaliceUser().
> ContainerManager.startContainer needs to only have ContainerTokenIdentifier
> instead of the whole Container
> ----------------------------------------------------------------------------------------------------------
>
> Key: YARN-684
> URL: https://issues.apache.org/jira/browse/YARN-684
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Vinod Kumar Vavilapalli
> Assignee: Vinod Kumar Vavilapalli
> Attachments: YARN-684.20130529.txt, YARN-684.20130530.4.txt
>
>
> The NM only needs the token, the whole Container is unnecessary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
