[
https://issues.apache.org/jira/browse/YARN-692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13671941#comment-13671941
]
Omkar Vinit Joshi commented on YARN-692:
----------------------------------------
NMToken now will have below information
* ApplicationAttemptId
* NodeId
* ApplicationSubmitter
* MasterKeyId
bq. NodeId instead of nodeHostAddr?
bq. It should be per ApplicationAttemptID as it is given to AMs.
Fixed..
bq. Why setters? Don't think we need them. If so, mark the class fields as
final.
Removed setters... Can't mark field as final as the are updated as a part of
NMTokenIdentifier#readFields
bq. getUser() -> ApplicationAttemptID?
Fixed..
bq. The changes to common SecretManager can be avoided if you pass in the
generatedKey also as an argument to MasterKeyData constructor.
Fixed..
bq. newNMToken can avoid passing NodeID once we move NMTokenIdentifier to use
NodeID.
Fixed.. moved to BaseNMTokenSecretManager
bq. RMNMTokenSecretManager: Unused field. Can be added later if it is needed in
the followup patches.
Ok will add it in YARN-693
bq. NMNMTokenSecretManager.appStarted is not needed?
agree.. fixed.
bq. RMNMTokenSecretManager -> NMTokenSecretManagerInRM and
NMNMTokenSecretManager -> NMTokenSecretManagerInNM?
:)
> Creating NMToken master key on RM and sharing it with NM as a part of RM-NM
> heartbeat.
> --------------------------------------------------------------------------------------
>
> Key: YARN-692
> URL: https://issues.apache.org/jira/browse/YARN-692
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Omkar Vinit Joshi
> Assignee: Omkar Vinit Joshi
> Attachments: YARN-692.20130530.1.patch, YARN-692.20130530.2.patch,
> YARN-692.20130531.1.patch, YARN-692.20130531.patch
>
>
> This is related to YARN-613 . Here we will be implementing NMToken generation
> on RM side and sharing it with NM during RM-NM heartbeat. As a part of this
> JIRA mater key will only be made available to NM but there will be no
> validation done until AM-NM communication is fixed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
