[ https://issues.apache.org/jira/browse/YARN-717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13671946#comment-13671946 ]
Vinod Kumar Vavilapalli commented on YARN-717: ---------------------------------------------- The patch looks good to me. Huge patch, but straightforward. +1. Will run tests, wait for Jenkins and them commit it. > Copy BuilderUtil methods into token-related records > --------------------------------------------------- > > Key: YARN-717 > URL: https://issues.apache.org/jira/browse/YARN-717 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Jian He > Assignee: Jian He > Attachments: YARN-717.1.patch, YARN-717.2.patch, YARN-717.3.patch > > > This is separated from YARN-711,as after changing yarn.api.token from > interface to abstract class, eg: ClientTokenPBImpl has to extend two classes: > both TokenPBImpl and ClientToken abstract class, which is not allowed in JAVA. > We may remove the ClientToken/ContainerToken/DelegationToken interface and > just use the common Token interface -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira