[
https://issues.apache.org/jira/browse/YARN-750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13674582#comment-13674582
]
Bikas Saha commented on YARN-750:
---------------------------------
+1. Looks good overall. Need a jira for FIFO scheduler changes.
Minor comments.
Empty block of code?
{code}
+
+ if (request.getBlacklistRequest() != null) {
+
+ }
// sanity check
{code}
Probably would be better if javadoc treated blacklisting * as one case of an
invalid blacklist exception. unlikely that we will be creating multiple such
exceptions.
{code}
+ * The exception is thrown when an application tries to blacklist
+ * {@link ResourceRequest#ANY}.
+ */
+public class InvalidBlacklistRequestException extends YarnRuntimeException {
{code}
TestApplicationTokens - change probably isnt needed
{code}
allocateRequest.setApplicationAttemptId(applicationAttemptId);
+ allocateRequest.setBlacklistRequest(
+ Records.newRecord(BlacklistRequest.class));
{code}
> Allow for black-listing resources in CS
> ---------------------------------------
>
> Key: YARN-750
> URL: https://issues.apache.org/jira/browse/YARN-750
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Arun C Murthy
> Assignee: Arun C Murthy
> Attachments: YARN-750.patch, YARN-750.patch, YARN-750.patch,
> YARN-750.patch, YARN-750.patch, YARN-750.patch
>
>
> YARN-392 and YARN-398 enhance scheduler api to allow for white-lists of
> resources.
> This jira is a companion to allow for black-listing (in CS).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
