Vinod Kumar Vavilapalli commented on YARN-752:

Haven't been paying attention. But quickly looked through.
 - I think if the user gives a wrong rack, we should throw an error.
 - IIUC, this code will change after YARN-521 or is YARN-521 just a new API 
instead of changes to the current API with optional flags?
 - In any case, the algo should eventually look like
For each explicitly added rack, if it doesn't exist, throw error;
if (asking for specific nodes) {
  don't add racks
} else {
  add racks
 - Either ways I think YARN-521 is a priority, depend on how the API is 
designed, it can result in API signature changes.

If you agree that the logic is based on enabling/disabling strict allocations, 
the following in the patch won't be correct any longer, right?
+   * documentation should be consulted for the specifics of how the parameters
+   * are honored."
> In AMRMClient, automatically add corresponding rack requests for requested 
> nodes
> --------------------------------------------------------------------------------
>                 Key: YARN-752
>                 URL: https://issues.apache.org/jira/browse/YARN-752
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: api, applications
>    Affects Versions: 2.0.4-alpha
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>         Attachments: YARN-752-1.patch, YARN-752-1.patch, YARN-752-2.patch, 
> YARN-752.patch
> A ContainerRequest that includes node-level requests must also include 
> matching rack-level requests for the racks that those nodes are on.  When a 
> node is present without its rack, it makes sense for the client to 
> automatically add the node's rack.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to