[ 
https://issues.apache.org/jira/browse/YARN-782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13680150#comment-13680150
 ] 

Hadoop QA commented on YARN-782:
--------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12587178/YARN-782.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/1186//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/1186//console

This message is automatically generated.
                
> vcores-pcores ratio functions differently from vmem-pmem ratio in misleading 
> way 
> ---------------------------------------------------------------------------------
>
>                 Key: YARN-782
>                 URL: https://issues.apache.org/jira/browse/YARN-782
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: nodemanager
>    Affects Versions: 2.0.4-alpha
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>            Priority: Critical
>         Attachments: YARN-782.patch
>
>
> The vcores-pcores ratio functions differently from the vmem-pmem ratio in the 
> sense that the vcores-pcores ratio has an impact on allocations and the 
> vmem-pmem ratio does not.
> If I double my vmem-pmem ratio, the only change that occurs is that my 
> containers, after being scheduled, are less likely to be killed for using too 
> much virtual memory.  But if I double my vcore-pcore ratio, my nodes will 
> appear to the ResourceManager to contain double the amount of CPU space, 
> which will affect scheduling decisions.
> The lack of consistency will exacerbate the already difficult problem of 
> resource configuration.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to